-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code cleanup #134
Comments
This is from one of the comments in above link
More info on pre-receive hook |
Thoughts on 80 column rule? Maybe use two spaces to fit easily in 80 columns? |
That's actually one of the parts that bothers me most about google coding style, the contortions needed to fit in 80 characters. It's 2017 so we don't have 640x480 or 720x480 screens anymore... I have a 4k screen. Preferably 320 columns, maybe 160 columns would be okay with me, 80 is definitely too low. Nice visualization of this point below, I don't really need to fit 8 code files side by side. :-) |
Even I think 80 is too low. But need an upperbound and wrap it, 160 seems reasonable. |
On Mon, Feb 13, 2017 at 4:17 PM tdinesh ***@***.***> wrote:
Even I think 80 is too low. But need an upperbound and wrap it, 160 seems
reasonable.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#134 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADZwGVHGXpKRb1nJdxq4txK4iYh8VFwks5rcMhmgaJpZM4L_qe7>
.
Sure good enough
--
Cheers!
Andrew Hundt
|
I've had a request for code cleanup, so I wanted to lay out the steps necessary to incorporate such a change.
At this point I've generally prioritized accepting contributions over code consistency for practical reasons, plus some code (like the vrep skeleton) is from other projects thus not easy to change the indentation because new updates will put it back. I've also preferred to be able to see who made what change over indentation fixes via git blame type commands.
When I can, I try to use the coding style of boost and indentation with four spaces not tabs. Some of the code is from various people/sources, particularly in some non-public repositories that use grl and code from v-rep's distribution.
I’d be happy to switched to a specific coding style, but there would be a couple requirements (which is why I haven’t done this yet):
As you can see this will take some time… so I haven’t taken care of it but a contribution is definitely welcome. Once an approach has been discussed and agreed upon plus a pull request made, I can do steps where project owner permissions are required. :-)
The text was updated successfully, but these errors were encountered: