adding error prone testing

ahus1 · Jul 21, 2018 · d53dea2 · d53dea2
1 parent e503253
commit d53dea2
Show file tree

Hide file tree

Showing 9 changed files with 30 additions and 4 deletions.
diff --git a/keycloak-dropwizard-bearer/src/main/resources/assets/ajax/app.js b/keycloak-dropwizard-bearer/src/main/resources/assets/ajax/app.js
@@ -34,7 +34,7 @@ var loadData = function () {
                 document.getElementById('draw').innerHTML = html;
                 document.getElementById('drawdate').innerHTML = draw.date;
                 document.getElementById('message').innerHTML = '';
-                document.getElementById('result').style = '';
+                document.getElementById('result').style.display = 'block';
             } else {
                 document.getElementById('message').innerHTML = req.responseText
             }

diff --git a/...k-dropwizard-bearer/src/test/java/de/ahus1/lottery/adapter/dropwizard/pages/DrawPage.java b/...k-dropwizard-bearer/src/test/java/de/ahus1/lottery/adapter/dropwizard/pages/DrawPage.java
@@ -1,9 +1,10 @@
 package de.ahus1.lottery.adapter.dropwizard.pages;
 
+import org.jboss.arquillian.graphene.Graphene;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.support.FindBy;
 
-import java.io.IOException;
+import java.util.concurrent.TimeUnit;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
@@ -15,11 +16,13 @@ public class DrawPage extends Page {
     @FindBy(name = "logout")
     private WebElement linkLogout;
 
+    @Override
     public void verify() {
-        assertThat(areaResult.isDisplayed());
+        Graphene.waitAjax().withTimeout(30, TimeUnit.SECONDS).until().element(areaResult).is().visible();
+        assertThat(areaResult.isDisplayed()).isTrue();
     }
 
-    public LoginPage logout() throws IOException {
+    public LoginPage logout() {
         linkLogout.click();
         LoginPage page = createPage(LoginPage.class);
         page.setReturnPage(StartPage.class);

diff --git a/...-dropwizard-bearer/src/test/java/de/ahus1/lottery/adapter/dropwizard/pages/LoginPage.java b/...-dropwizard-bearer/src/test/java/de/ahus1/lottery/adapter/dropwizard/pages/LoginPage.java
@@ -25,6 +25,7 @@ public class LoginPage<T extends Page> extends Page {
 
     private Class<T> clazz;
 
+    @Override
     public void verify() {
         assertThat(browser.getTitle()).isEqualTo("Log in to test");
     }

diff --git a/...-dropwizard-bearer/src/test/java/de/ahus1/lottery/adapter/dropwizard/pages/StartPage.java b/...-dropwizard-bearer/src/test/java/de/ahus1/lottery/adapter/dropwizard/pages/StartPage.java
@@ -22,6 +22,7 @@ public class StartPage extends Page {
     @FindBy(name = "draw")
     private WebElement buttonDraw;
 
+    @Override
     public void verify() {
         assertThat(browser.getTitle()).isEqualTo("Lottery Calculator");
     }

diff --git a/...wizard-bearermodule/src/test/java/de/ahus1/lottery/adapter/dropwizard/pages/DrawPage.java b/...wizard-bearermodule/src/test/java/de/ahus1/lottery/adapter/dropwizard/pages/DrawPage.java
@@ -15,6 +15,7 @@ public class DrawPage extends Page {
     @FindBy(name = "logout")
     private WebElement linkLogout;
 
+    @Override
     public void verify() {
         assertThat(areaResult.isDisplayed());
     }

diff --git a/...izard-bearermodule/src/test/java/de/ahus1/lottery/adapter/dropwizard/pages/LoginPage.java b/...izard-bearermodule/src/test/java/de/ahus1/lottery/adapter/dropwizard/pages/LoginPage.java
@@ -25,6 +25,7 @@ public class LoginPage<T extends Page> extends Page {
 
     private Class<T> clazz;
 
+    @Override
     public void verify() {
         assertThat(browser.getTitle()).isEqualTo("Log in to test");
     }

diff --git a/...izard-bearermodule/src/test/java/de/ahus1/lottery/adapter/dropwizard/pages/StartPage.java b/...izard-bearermodule/src/test/java/de/ahus1/lottery/adapter/dropwizard/pages/StartPage.java
@@ -22,6 +22,7 @@ public class StartPage extends Page {
     @FindBy(name = "draw")
     private WebElement buttonDraw;
 
+    @Override
     public void verify() {
         assertThat(browser.getTitle()).isEqualTo("Lottery Calculator");
     }

diff --git a/keycloak-dropwizard/src/main/java/de/ahus1/keycloak/dropwizard/User.java b/keycloak-dropwizard/src/main/java/de/ahus1/keycloak/dropwizard/User.java
@@ -22,6 +22,7 @@ public void checkUserInRole(String role) {
         }
     }
 
+    @Override
     public String getName() {
         return securityContext.getToken().getName();
     }

diff --git a/pom.xml b/pom.xml
@@ -56,6 +56,7 @@
     <packaging>pom</packaging>
 
     <properties>
+        <encoding>UTF-8</encoding>
         <checkstyle.version>6.18</checkstyle.version>
         <keycloak.version>3.4.3.Final</keycloak.version>
         <dropwizard.version>1.3.5</dropwizard.version>
@@ -91,9 +92,25 @@
                 <artifactId>maven-compiler-plugin</artifactId>
                 <version>3.2</version>
                 <configuration>
+                    <compilerId>javac-with-errorprone</compilerId>
+                    <forceJavacCompilerUse>true</forceJavacCompilerUse>
                     <source>1.8</source>
                     <target>1.8</target>
                 </configuration>
+                <dependencies>
+                    <dependency>
+                        <groupId>org.codehaus.plexus</groupId>
+                        <artifactId>plexus-compiler-javac-errorprone</artifactId>
+                        <version>2.8.3</version>
+                    </dependency>
+                    <!-- override plexus-compiler-javac-errorprone's dependency on
+                         Error Prone with the latest version -->
+                    <dependency>
+                        <groupId>com.google.errorprone</groupId>
+                        <artifactId>error_prone_core</artifactId>
+                        <version>2.3.1</version>
+                    </dependency>
+                </dependencies>
             </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>