-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
123 body index refactor modularization #124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would like to see some unit tests here given the complexity of the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the reorganization of the code. I feel like I can undeestand more easily what is happening and where I can find what I need. As for the issue with the tiff image. It seems to be fix as I didn't have any issue doing a classification
Image appear the first time, and the bouding box are around the seeds
9299eeb
to
195392b
Compare
07520c2
to
a5e4da1
Compare
a5e4da1
to
ea59551
Compare
named component file cleanup common api
test view test seed cacheutils tests 2/8 functions
body test hook tests hook test body test initial state More tests null guards Fix useDecoderTiff test Exclude decoder tests due to browser dependencies Fix lint Body test mock axios Api throws Fix tests Fix explicit false
This PR moves majority of the algorithms out of the Body component into a common module so that unit testing of these functions and debugging is less complicated.
Common Module
Hooks Module
Quality of life changes
Pure Functions
Body Component
directory_list
Unit Tests
Fixes