Added felt-pen & More accurate benchmarking #21
Conversation
nin-jin
commented
Sep 26, 2021
•
edited
edited
Cool lib!
|
This is a stolen library. Ai removed the git history and author, asked people to switch, and when caught, asked the real author to credit him. Do not support this person. |
@StoneCypher I mentioned I am asking |
@@ -17,36 +18,42 @@ function formatNumber(number) { | |||
} | |||
|
|||
let suite = new benchmark.Suite() | |||
let out // eslint-disable-line no-unused-vars |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove it if it is not used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add out =
to benchmarks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JIT can throw out content of pure functions if result isn't used. It's relevant for simple benchmark but not complex. I will remove it.
It's prevent JIT from inline const string. |
Wow! Cool idea! |
It's extremely gross that after you were caught ripping off every line, without ever saying that you did anything wrong, you're pointing the finger at him over minor tuning of his own code. You should have submitted a PR to his library. |