Skip to content
This repository has been archived by the owner on Nov 22, 2021. It is now read-only.

kleur/colors #4

Closed
lukeed opened this issue Sep 21, 2021 · 6 comments
Closed

kleur/colors #4

lukeed opened this issue Sep 21, 2021 · 6 comments

Comments

@lukeed
Copy link

lukeed commented Sep 21, 2021

Hey, welcome to the color space lol

You should be benching against kleur/colors module since that's the direct comparison to yours and colorette. The root kleur module is the chalk API which is slower, slower to load, and not tree shakable by design.

Thanks :)

@ai
Copy link
Owner

ai commented Sep 21, 2021

Sure! Can you send a PR and change benchmarks?

I am not sure how to benchmark require speed. Am I right that you are using kleur/colors in kleur import (so they will re-use reuquire cache between benchmarks)?

@lukeed
Copy link
Author

lukeed commented Sep 21, 2021

No they're completely separate modules, no code share. I can't send a PR sorry, but here's the API for it: https://github.com/lukeed/kleur#individual-colors (require is ok)

@ai
Copy link
Owner

ai commented Sep 21, 2021

Don’t worry. I will add benchmark later today or tomorrow.

@lukeed
Copy link
Author

lukeed commented Sep 21, 2021

Cool, thanks!

@ai
Copy link
Owner

ai commented Sep 21, 2021

Really great results 👍 Thanks for explaining the best way to compare tools.

56430e3

@lukeed
Copy link
Author

lukeed commented Sep 21, 2021

Cool, thanks 👍 Cheers

@lukeed lukeed closed this as completed Sep 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants