-
-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nanoid in Go #21
Comments
Definitely better work,
Surely add it.
Matouš Dzivjak
… On 13 Sep 2017, at 16:22, Alberto Schiabel ***@***.***> wrote:
Disclaimer
I am aware of #20.
The fact is that I wasn't aware of it 24 hours ago, when I started playing around with this port of mine.
Description
I have documented well my code, added references to the original repo (you can see many Github links inside nanoid.go and ported the test suite at test/index.test.js).
The main difference with matoous/go-nanoid is that I've strictly followed the original API. Thus, I feel it would be nice to add a link to my repo just below @matoous'
Thus the last part of README.md would become:
Other Programming Languages
Go
go-nanoid (uses a different API)
nanoid (user pretty much the same API as this original repo)
PHP
nanoid-php
@ai, what do you thunk about it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Why would you suggest that one link is better than two? I'd agree with you if the APIs of the two Go projects were similar, but they aren't |
BTW, if that means something to you, mine already has Travis CI up and running without issues |
The choice is always hard for users. In this case, we really don’t need 2 solutions. Can you imagine that one developer will choice one library for one project and another library for another project? Instead of given hard choice we should select the best API and promote it. |
Well,
Decide which one, I have no arguments agains that :) although I don't want to give up on my project :(
Matouš Dzivjak
… On 14 Sep 2017, at 16:32, Andrey Sitnik ***@***.***> wrote:
The choice is always hard for users. In this case, we really don’t need 2 solutions. Can you imagine that one developer will choice one library for one project and another library for another project? Instead of given hard choice we should select the best API and promote it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
It's ok for me, but I dread that my PR would almost completely overwrite his code. Uhm, @matoous, how would you like to proceed? |
Sorry, I quite don't understand, what exactly do you propose?
Matouš Dzivjak
… On 14 Sep 2017, at 22:29, Alberto Schiabel ***@***.***> wrote:
It's ok for me, but I dread that my PR would almost completely overwrite his code. Uhm, @matoous, how would you like to proceed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Disclaimer
I am aware of #20.
The fact is that I wasn't aware of it 24 hours ago, when I started playing around with this port of mine.
Description
I have documented well my code, added references to the original repo (you can see many Github links inside nanoid.go and ported the test suite at test/index.test.js).
The main difference with matoous/go-nanoid is that I've strictly followed the original API. Thus, I feel it would be nice to add a link to my repo just below @matoous'
Thus the last part of README.md would become:
Other Programming Languages
@ai, what do you thunk about it?
The text was updated successfully, but these errors were encountered: