Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nanoid in Go #21

Closed
jkomyno opened this issue Sep 13, 2017 · 10 comments
Closed

nanoid in Go #21

jkomyno opened this issue Sep 13, 2017 · 10 comments

Comments

@jkomyno
Copy link

jkomyno commented Sep 13, 2017

Disclaimer

I am aware of #20.
The fact is that I wasn't aware of it 24 hours ago, when I started playing around with this port of mine.

Description

I have documented well my code, added references to the original repo (you can see many Github links inside nanoid.go and ported the test suite at test/index.test.js).

The main difference with matoous/go-nanoid is that I've strictly followed the original API. Thus, I feel it would be nice to add a link to my repo just below @matoous'

Thus the last part of README.md would become:

Other Programming Languages

@ai, what do you thunk about it?

@matoous
Copy link
Contributor

matoous commented Sep 13, 2017 via email

@jkomyno
Copy link
Author

jkomyno commented Sep 13, 2017

Thanks a lot @matoous!
PR added here: #22

@ai
Copy link
Owner

ai commented Sep 14, 2017

One link is always better, than two. Let’s choose one project and put it to the docs.

Should we just take @jkomyno or send PR to @matoous implementation?

@jkomyno
Copy link
Author

jkomyno commented Sep 14, 2017

Why would you suggest that one link is better than two? I'd agree with you if the APIs of the two Go projects were similar, but they aren't

@jkomyno
Copy link
Author

jkomyno commented Sep 14, 2017

BTW, if that means something to you, mine already has Travis CI up and running without issues

@ai
Copy link
Owner

ai commented Sep 14, 2017

The choice is always hard for users. In this case, we really don’t need 2 solutions. Can you imagine that one developer will choice one library for one project and another library for another project? Instead of given hard choice we should select the best API and promote it.

@matoous
Copy link
Contributor

matoous commented Sep 14, 2017 via email

@ai
Copy link
Owner

ai commented Sep 14, 2017

@jkomyno do we have any problems why we can’t end PR to @matoous project? He was the first. Also, we should be welcome for first-time open source contribution.

I could send you PostCSS stickers if you will help @matoous on his project =^_^=

@jkomyno
Copy link
Author

jkomyno commented Sep 14, 2017

It's ok for me, but I dread that my PR would almost completely overwrite his code. Uhm, @matoous, how would you like to proceed?

@matoous
Copy link
Contributor

matoous commented Sep 15, 2017 via email

@ai ai closed this as completed Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants