-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a technical explanation of the 256 character cap on the alphabet #35
Comments
It is just algorithm limits. Symbols on I change text a little 9796c48 Maybe you can do it better. |
If you didn’t want to explain it better, I will release 1.0. |
You'll want to address the language here: Line 4 in 039fe3f
Which states "Alphabet must contain 256 symbols or less. Otherwise, the generator will not be secure.". It's both wrong because it should be "less than 256 symbols", and also the part about it "not being secure" is confusing. And possibly add a length check in the function to throw an appropriate error for alphabets greater than 255 characters. |
Nope, random byte has values between
I am open for suggestion :). It is less secure because we use random bytes per symbol, so any
Do you know real cases for this? ;) |
I was just going off the language you used in the commit you were referencing (9796c48), which stated "Only alphabets with less than 256 symbols are supported." Either format.js is wrong or the README is wrong as they conflict. :) |
Ouh, understand :). I copied text from |
The README says the "alphabet must contain less than 256 symbols.". It would be nice to have a technical explanation of why. Hopefully something more than "It will not be secure." :)
The text was updated successfully, but these errors were encountered: