Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vietnamese #131

Merged
merged 1 commit into from Oct 28, 2015
Merged

add vietnamese #131

merged 1 commit into from Oct 28, 2015

Conversation

nguyenvanduocit
Copy link

No description provided.

@ai
Copy link
Member

ai commented Oct 27, 2015

You need also translate r18n-core/base/en.yml to r18n-core/base/vi.yml

@ai
Copy link
Member

ai commented Oct 27, 2015

Also, why you use vi-vn instead of vi locale? Does this Vietnamese language are dialect? Like en-GB and en-US?

@ai
Copy link
Member

ai commented Oct 27, 2015

Sunday and other locale is correct.

@ai
Copy link
Member

ai commented Oct 27, 2015

Is it the best date format ngày 3 tháng 1 năm 2015‎? (I take it from Wikipedia)

What is algorithms for it? (Do not worry, I will write it in Ruby, just describe the idea)

@nguyenvanduocit
Copy link
Author

yeah, in Vietnamese, we have three way to describe about date.
Example for 03/01/2015 ( day/month/year )

  • "Ngày 3 tháng 1 năm 2015" is the long format
  • " ngày 3, Th1, 2015" is short format
  • 03/01/2015

No need "th", "nd",.. after day number.

hope you can help to fix it, I don't know anything about ruby, it's not familar with me.

@nguyenvanduocit
Copy link
Author

I use vi-vn because I saw it in my website header lol, I just look at the RFC 3066 language codes. It must be 'vi'

ai added a commit that referenced this pull request Oct 28, 2015
@ai ai merged commit 2451f56 into r18n:master Oct 28, 2015
@ai
Copy link
Member

ai commented Oct 28, 2015

@nguyenvanduocit can you please send second PR with translation r18n-core/base/en.yml to r18n-core/base/vi.yml?

@nguyenvanduocit
Copy link
Author

ok

@ai
Copy link
Member

ai commented Oct 29, 2015

I also fixed date formatter. Let’s check it:

05:29, 29/10/2015
05:35, ngày 29 tháng 10 năm 2015

@nguyenvanduocit
Copy link
Author

Ok, that right. you are awesome, now, are easings.net ready for merge ?

@ai
Copy link
Member

ai commented Oct 29, 2015

@nguyenvanduocit we still need to translate r18n-core/base/en.yml to r18n-core/base/vi.yml. But it is last thing :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants