Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra blank lines when using --silent #363

Open
isuvorov opened this issue May 22, 2024 · 1 comment
Open

Extra blank lines when using --silent #363

isuvorov opened this issue May 22, 2024 · 1 comment

Comments

@isuvorov
Copy link
Contributor

Extra blank lines appear when using the --silent option.

I propose add a check if (isSilentMode) in the appropriate parts of the code to fix this issue.

function createHumanReporter(process, isSilentMode = false) {
  function print(...lines) {
    if (!isSilentMode) {
      process.stdout.write('  ' + lines.join('\n  ') + '\n')
    }
  }

process.stdout.write(' ' + lines.join('\n ') + '\n')

Need advice on the correctness of this approach.

I could make PR by myself.

This gap is too БЕСИТ 😬

image image image
@ai
Copy link
Owner

ai commented May 23, 2024

Yes, let’s remove spaces for silent mode. Create PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants