-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output --why webpack build for CI purposes #66
Comments
Do I understand correctly that you want In this case, just add Webpack Bundle Analyzer to your custom config. Maybe we can do it automatically? Like changing webpack config in Size Limit. Do you want to send PR? (I am preparing for the conference and will be able to do it only in next week). |
I guess i'm trying to understand where the build is being stored. If I could customize it using CLI I could then store it using CircleCI to define temp folders which are copied into my artifacts. See documentation here. https://circleci.com/docs/2.0/artifacts/ I can try to get a PR up this weekend if this is something that would be useful for other consumers as well. 😄 |
@jeffredodd Size Limit builds a project in memory. So you will not find it on the disk. Why do you need to find it? |
@ai The purpose of this is to store the information on a per build basis. I work in a repository that receives a lot of internal contributions daily and we store our test coverage data in artifacts so we have a historical reference to the values at build time. This helps us during investigations say on why test coverage decreased, when, why it happened, etc. We are hoping to do the same thing with SizeLimit, and by storing the output of |
@jeffredodd Got it. Do you want to store total bundle size or you want to store the whole |
Usually we store the whole webpack bundle or |
There are 2 options:
|
Do you have custom webpack config right now? |
@jeffredodd Sorry to bother you here but I didn't find any other way to contact you: What's your experience so far with using build artifacts for historical data? The circle CI documentation says that there is no guarantee about storage duration and that artifacts should only be used around build time. I would like to use build artifacts for historical analysis of our builds but the statements on the documentation lead me to believe that they're not appropriate for those things.
|
I wanted to confirm, does that option exist today or are you suggesting this would be a good capability for someone to add via PR? |
@mflores-verys sorry for the long delay. Had hard times because of the conference.
Size Limit doesn’t have this option. If you want to send PR, I will help you and accept it. |
Hello,
As a user of CircleCI (or any other CI system), I would like to be able to store the output of the
--why
functionality in my build artifacts. This would allow me to use size limit to visually see what changed between builds, something that becomes rather complex over a large amount of commits.If this is something that is possible I'd love to contribute.
Cheers,
Jeffrey
The text was updated successfully, but these errors were encountered: