Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SyntaxError: Unexpected identifier (in size-limit/node_modules/read-pkg-up/index.js:6) #88

Closed
avdeev opened this issue Apr 1, 2019 · 2 comments

Comments

@avdeev
Copy link

avdeev commented Apr 1, 2019

Perhaps regression on v1

> @ size /builds/my-project
> size-limit

/builds/my-project/node_modules/size-limit/node_modules/read-pkg-up/index.js:6
module.exports = async options => {
                       ^^^^^^^
SyntaxError: Unexpected identifier
    at Object.exports.runInThisContext (vm.js:76:16)
    at Module._compile (module.js:528:28)
    at Object.Module._extensions..js (module.js:565:10)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (module.js:483:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/builds/my-project/node_modules/size-limit/cli.js:14:15)
    at Module._compile (module.js:556:32)
@avdeev avdeev changed the title SyntaxError: Unexpected identifier SyntaxError: Unexpected identifier (size-limit/node_modules/read-pkg-up/index.js:6) Apr 1, 2019
@avdeev avdeev changed the title SyntaxError: Unexpected identifier (size-limit/node_modules/read-pkg-up/index.js:6) SyntaxError: Unexpected identifier (in size-limit/node_modules/read-pkg-up/index.js:6) Apr 1, 2019
@avdeev
Copy link
Author

avdeev commented Apr 1, 2019

Reproduce on Node.js < 6.
https://github.com/sindresorhus/read-pkg-up/releases/tag/v5.0.0

@avdeev avdeev closed this as completed Apr 1, 2019
@ai
Copy link
Owner

ai commented Apr 1, 2019

Do not worry, on Travis CI Size Limit will not be executed on old Node.js (because Size Limit is heavy, but result is the same for all Node.js version). So you can still use Size Limit for Node.js 4-6, just put latest Node.js as a first Node.js versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants