Unable to add bot to unrated game with no title restrictions

[theblankman]

Tried to play an unrated game against a bot, the bot could not join. Salvager v2.5.4.0 beta. Bot could join with Salvager 2.5.1.6.

JS Console output:

Uncaught Invalid server message type: ADD_EXTUSER connection.js:101
Uncaught Invalid server message type: REM_EXTUSER connection.js:101
2
Uncaught Invalid server message type: REM_EXTUSER connection.js:101
Uncaught Invalid server message type: REM_EXTUSER connection.js:101
Uncaught Invalid server message type: REM_EXTUSER connection.js:101
Uncaught Invalid server message type: ADD_EXTUSER connection.js:101
Uncaught Invalid server message type: ADD_EXTUSER connection.js:101
Uncaught TypeError: Cannot read property 'ratingPro' of undefined autokick.js:32
3
Uncaught Required parameter missing and has no default.  Message = InviteBotTableToken, parameter = token due to token not a string FSSDK.js:11917
2
Uncaught Invalid server message type: ADD_EXTUSER connection.js:101
Uncaught Invalid server message type: REM_EXTUSER connection.js:101
Uncaught Invalid server message type: ADD_EXTUSER connection.js:101
GS.WS.conn.onmessage connection.js:101
Uncaught Invalid server message type: REM_EXTUSER connection.js:101
GS.WS.conn.onmessage connection.js:101

[aiannacc]

Good catch. Thanks for reporting it.

It looks like the problem is the pro rating cache I created. Players only get added to it when they enter the lobby, so bots get skipped and you get "undefined" when you query the cache for them.

Probably the easiest fix is to move the opp.get('isBot') check to the top of the autokick callback and just short-circuit the whole process.

[michaeljb]

Fixed in #205