Issue1058 #116
Closed
Issue1058 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 12, 2022 14:45
…logger; measure pruning time only with verbose verbosity
| @@ -20,7 +21,7 @@ LimitedPruning::LimitedPruning(const Options &opts) | |||
| void LimitedPruning::initialize(const shared_ptr<AbstractTask> &task) { | |||
| PruningMethod::initialize(task); | |||
| pruning_method->initialize(task); | |||
| utils::g_log << "pruning method: limited" << endl; | |||
| log << "pruning method: limited" << endl; | |||
There was a problem hiding this comment.
We probably don't want to print this in silent mode?
| void NullPruningMethod::initialize(const shared_ptr<AbstractTask> &task) { | ||
| PruningMethod::initialize(task); | ||
| utils::g_log << "pruning method: none" << endl; | ||
| log << "pruning method: none" << endl; |
| atom_selection_strategy(opts.get<AtomSelectionStrategy>("atom_selection_strategy")) { | ||
| } | ||
|
|
||
| void StubbornSetsAtomCentric::initialize(const shared_ptr<AbstractTask> &task) { | ||
| StubbornSets::initialize(task); | ||
| utils::g_log << "pruning method: atom-centric stubborn sets" << endl; | ||
| log << "pruning method: atom-centric stubborn sets" << endl; |
| @@ -122,7 +126,7 @@ void StubbornSetsEC::initialize(const shared_ptr<AbstractTask> &task) { | |||
| disabled.resize(num_operators); | |||
| disabled_computed.resize(num_operators, false); | |||
|
|
|||
| utils::g_log << "pruning method: stubborn sets ec" << endl; | |||
| log << "pruning method: stubborn sets ec" << endl; | |||
| void StubbornSetsSimple::initialize(const shared_ptr<AbstractTask> &task) { | ||
| StubbornSets::initialize(task); | ||
| interference_relation.resize(num_operators); | ||
| interference_relation_computed.resize(num_operators, false); | ||
| utils::g_log << "pruning method: stubborn sets simple" << endl; | ||
| log << "pruning method: stubborn sets simple" << endl; |
| /* | ||
| We only measure time with verbose verbosity level because time | ||
| measurements induce a significant overhead, up to 30% for configurations | ||
| like blind search. See issue1042 and issue1058. |
There was a problem hiding this comment.
Perhaps add "with the NullPruning method" after "like blind search"?
| class PruningMethod { | ||
| utils::Timer timer; | ||
| friend class limited_pruning::LimitedPruning; | ||
|
|
||
| virtual void prune( | ||
| const State &state, std::vector<OperatorID> &op_ids) = 0; | ||
| protected: | ||
| mutable utils::LogProxy log; |
There was a problem hiding this comment.
I assume this does have to be mutable? It's not pretty.
There was a problem hiding this comment.
Yes, unfortunately, because output streams are modified when used.
There was a problem hiding this comment.
If we think it is OK to do output on const logs, it would probably be good to encapsulate this inside the LogProxy class. But that's something for another issue then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.