Issue1070 #141
Merged
Issue1070 #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClemensBuechner
force-pushed
the
issue1070
branch
from
e2c2ae3
to
bc33b9b
Compare
ClemensBuechner
force-pushed
the
issue1070
branch
from
d4bb4a6
to
b9f398d
Compare
| return false. If a simple landmark can be achieved, return only operators | ||
| that achieve simple landmarks, else return operators that achieve | ||
| disjunctive landmarks */ | ||
| bool LandmarkCountHeuristic::generate_helpful_actions(const State &state) { |
There was a problem hiding this comment.
We should clean up the signature: there is no longer a reason to have this be a non-void function. The general preference is for mutating functions like these ones to be void; the return value is not obvious from the name and is unused. Also, the function name should be generate_preferred_operators; "helpful actions" is an EHC/FF term. If we make this void, the following comment also should be adjusted.
There was a problem hiding this comment.
This also entails changing the variable names that use "ha", and I wouldn't mix "action" and "operator" in the same comment, as in "Find actions that... return operators that...". Also, the function doesn't actually return operators.
ClemensBuechner
force-pushed
the
issue1070
branch
from
060f268
to
514535d
Compare
…t of reached landmarks.
ClemensBuechner
force-pushed
the
issue1070
branch
from
514535d
to
079d9d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.