Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue1130 #203

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Issue1130 #203

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf69dd6
Use bounds of component algorithms in iterated search.
ClemensBuechner Jan 8, 2024
d0a9b4c
Prettify unrelated code.
ClemensBuechner Jan 16, 2024
228db3f
Add document note.
ClemensBuechner Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/search/search_algorithms/iterated_search.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,7 @@ shared_ptr<SearchAlgorithm> IteratedSearch::create_current_phase() {
this overrides continue_on_fail.
*/
if (repeat_last_phase && last_phase_found_solution) {
return get_search_algorithm(
algorithm_configs.size() -
1);
return get_search_algorithm(algorithm_configs.size() - 1);
} else {
return nullptr;
}
Expand All @@ -63,7 +61,7 @@ SearchStatus IteratedSearch::step() {
if (!current_search) {
return found_solution() ? SOLVED : FAILED;
}
if (pass_bound) {
if (pass_bound && best_bound < current_search->get_bound()) {
current_search->set_bound(best_bound);
}
++phase;
Expand Down Expand Up @@ -184,6 +182,18 @@ class IteratedSearchFeature : public plugins::TypedFeature<SearchAlgorithm, Iter
"(using heuristic predefinition) between iterations, "
"the path data (that is, landmark status for each visited state) "
"will be saved between iterations.");
document_note(
"Semantics of Search Bounds",
"The definition of our interfaces for search algorithms allow to "
"set bounds for the iterated search and all its component search "
"algorithms individually. We do not see a reasonable use case "
"where setting a bound for a component search algorithm is "
"advisable. If this is done anyways, the bound of said search "
"iteration is set to the minimum of that bound and the overall "
"bound on the iterated search. This can be particularly relevant "
"when the option `pass_bound` is set to true in which case the "
"bound of the iterated search is updated whenever a better "
"solution is found by one of its components.");
}

virtual shared_ptr<IteratedSearch> create_component(const plugins::Options &options, const utils::Context &context) const override {
Expand Down