[issue1005] fix issue1005 #29
Conversation
| CPLEX_URL: ${{ secrets.CPLEX_URL }} | ||
| SOPLEX_URL: ${{ secrets.SOPLEX_URL }} | ||
| CPLEX_URL: ${{ secrets.CPLEX129_LINUX_URL }} | ||
| SOPLEX_URL: ${{ secrets.SOPLEX311_URL }} |
There was a problem hiding this comment.
I added 'LINUX' to the CPLEX key, because we have now the same key for Windows too (but with 'WINDOWS'). For SoPlex, I do not expect this necessary, as we are building from sources (once that works).
I added the version numbers to the secret. At least for Windows changing the CPLEX version is more than changing the secret to another URL.
| chmod +x $CPLEX_INSTALLER | ||
| ./$CPLEX_INSTALLER -DLICENSE_ACCEPTED=TRUE -DUSER_INSTALL_DIR="$(dirname "${DOWNWARD_CPLEX_ROOT}")" -i silent | ||
| rm $CPLEX_INSTALLER | ||
| wget -O cplex_installer $CPLEX_URL &> /dev/null |
There was a problem hiding this comment.
We should keep the installer files secret. Thus, the installer files have a random prefix. To no leak the prefix the '-O' option is used here.
README.md
Outdated
| On Ubuntu and Windows we compile with LP support using CPLEX 12.9, SoPlex | ||
| 3.1.1 and Osi 0.107.9. | ||
| We test LP support with CPLEX 12.9, SoPlex 3.1.1 and Osi 0.107.9. | ||
| On Ubuntu both CPLEX and SoPlex, on Windows only CPLEX is tested. |
There was a problem hiding this comment.
The second sentence should be rephrased: On Ubuntu, we test both CPLEX and SoPlex. On Windows, we currently only test CPLEX and on macOS, we do not test LP solvers (yet).
| set PATH=%PATH%;D:\a\downward\cplex_temp\opl\bin\x64_win64/ | ||
| cd misc/ | ||
| tox -e translator,search | ||
|
|
There was a problem hiding this comment.
only one empty line between the steps
No description provided.