Catch OverflowError when casting large ints to floats (#95).

Co-authored-by: Jendrik Seipp <jendrik.seipp@liu.se>
aibasel · Mar 23, 2021 · 16d8b34 · 16d8b34
1 parent b1d8109
commit 16d8b34
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/downward/reports/compare.py b/downward/reports/compare.py
@@ -137,7 +137,7 @@ def collect(self, table, cells):
                 values = [table[row_name].get(col_name, None) for col_name in col_names]
                 try:
                     diff = float(values[1]) - float(values[0])
-                except (ValueError, TypeError):
+                except (ValueError, TypeError, OverflowError):
                     diff = None
                 if diff is not None:
                     non_none_values.append(diff)

diff --git a/lab/tools.py b/lab/tools.py
@@ -432,7 +432,10 @@ def get_colors(cells, min_wins):
             min_wins = True
 
     # If we land here, both min_value and max_value are not None.
-    diff = float(max_value - min_value)
+    try:
+        diff = float(max_value - min_value)
+    except OverflowError:
+        return result
 
     for col, val in cells.items():
         if val is not None: