Take float precision into account when highlighting table cells.

aibasel · Sep 8, 2020 · beee39f · beee39f
1 parent 5e2b785
commit beee39f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/docs/news.rst b/docs/news.rst
@@ -6,6 +6,7 @@ v6.1 (unreleased)
 
 Lab
 ^^^
+* Take float precision into account when highlighting table cells (Jendrik Seipp).
 * Separate tests for Singularity and FF example experiments from other tests (Jendrik Seipp).
 * Skip ``cached_revision`` doctests if ``DOWNWARD_REVISION_CACHE`` variable is not set (Jendrik Seipp).
 * Add ``.github/CONTRIBUTING.md`` file (Jendrik Seipp).

diff --git a/lab/reports/__init__.py b/lab/reports/__init__.py
@@ -729,7 +729,8 @@ def _format_row(self, row_name, row):
             min_value, max_value = None, None
 
         def is_close(a, b):
-            return math.isclose(a, b)
+            # Highlight based on precision visible in table, not actual values.
+            return math.isclose(a, b, abs_tol=10 ** -self.digits)
 
         for col_name, value in row.items():
             color = None