Handled minor review comments

tools/ot/src/main/java/dk/alexandra/fresco/tools/ot/otextension/CoteShared.java

@@ -11,7 +11,7 @@
  * Superclass containing the common methods for the sender and
  * receiver parties of correlated OT with errors.
  */
-public class CoteShared {
+public abstract class CoteShared {
   private final int instanceId;
 
   /**

tools/ot/src/main/java/dk/alexandra/fresco/tools/ot/otextension/RotSharedImpl.java

@@ -11,7 +11,7 @@
  * Superclass containing the common variables and methods for the sender and
  * receiver parties of random OT extension.
  */
-public class RotSharedImpl {
+public abstract class RotSharedImpl {
   private final CoinTossing ct;
   private final int comSecParam;
   private final MessageDigest digest;

tools/ot/src/main/java/dk/alexandra/fresco/tools/ot/otextension/Transpose.java

@@ -12,10 +12,16 @@
  */
 public class Transpose {
 
+  private Transpose() {
+    /**
+     * This class is meant to only contain static helper methods.
+     */
+  }
+
   /**
    * Transposes, in-place, a matrix represent in row-major as a list of byte
    * arrays.
-   * 
+   *
    * @param input
    *          The matrix to transpose
    */
@@ -78,7 +84,7 @@ public static List<StrictBitVector> transpose(List<StrictBitVector> input) {
   /**
    * Complete the Eklundh algorithm for transposing with initial blocks of 8
    * bits. That is, assuming all blocks of 8 bits have already been transposed
-   * 
+   *
    * @param input
    *          The matrix to transpose. Represented in row-major
    */
@@ -100,7 +106,7 @@ private static void doEklundh(List<byte[]> input) {
 
   /**
    * Swaps the content of two square blocks, in-place.
-   * 
+   *
    * @param input
    *          The list of arrays of which to swap
    * @param row
@@ -124,7 +130,7 @@ private static void swap(List<byte[]> input, int row, int column,
 
   /**
    * Check that a matrix obeys the rules needed to do Eklundh transposing.
-   * 
+   *
    * @param input
    *          The matrix to check
    */
@@ -152,7 +158,7 @@ private static void doSanityCheck(List<StrictBitVector> input) {
 
   /**
    * Transpose all 8 bit squares in a square matrix, in-place.
-   * 
+   *
    * @param input
    *          The input
    */
@@ -169,7 +175,7 @@ private static void transposeAllByteBlocks(List<byte[]> input) {
   /**
    * Transposes 8x8 bit blocks of a row-major matrix, at positions "rowOffset",
    * "columnOffset".
-   * 
+   *
    * @param input
    *          The matrix to transpose
    * @param rowOffset
@@ -221,7 +227,7 @@ private static void transposeByteBlock(List<byte[]> input, int rowOffset,
 
   /**
    * Allocate a matrix in row-major form, as a list of byte arrays.
-   * 
+   *
    * @param rows
    *          Rows in the matrix
    * @param columns

tools/ot/src/test/java/dk/alexandra/fresco/tools/ot/otextension/TestTranspose.java

@@ -79,12 +79,6 @@ public void testSquareMatrix() {
     assertEquals(false, thrown);
   }
 
-  @Test
-  public void testNewTranspose() {
-    // Verify that it is possible to construct a Transpose object
-    new Transpose();
-  }
-
   @Test
   public void testBigMatrix() {
     boolean thrown = false;