Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The /deploy command should generate more descriptive tag #55

Closed
vpavlin opened this issue Aug 25, 2020 · 0 comments · Fixed by #56
Closed

The /deploy command should generate more descriptive tag #55

vpavlin opened this issue Aug 25, 2020 · 0 comments · Fixed by #56
Assignees
@goern
Labels
good first issue Good for newcomers hacktoberfest Issues targeting the hacktoberfest participants. human_intervention_required kind/feature Categorizes issue or PR as related to a new feature.
Projects
AICoE CI/CD Service

Comments

@vpavlin
Copy link

vpavlin commented Aug 25, 2020 •
edited
Loading

Describe the bug
Currently the image tag generated by /deploy command is just a PR number. That might get a bit confusing with potentially arbitrary versioning schemes and also looks "weird"

To Reproduce
Tag name is just a number

Screenshot from 2020-08-25 17-27-47

Expected behavior
The tag should be ideally a bit more descriptive something like - pr-XX (e.g. pr-56) or dev-XX (e.g. dev-56)
@vpavlin vpavlin added the bug label Aug 25, 2020
@goern goern added good first issue Good for newcomers hacktoberfest Issues targeting the hacktoberfest participants. kind/feature Categorizes issue or PR as related to a new feature. and removed bug labels Aug 25, 2020
@goern goern added this to New in AICoE CI/CD Service via automation Aug 25, 2020
@goern goern self-assigned this Aug 25, 2020
@goern goern mentioned this issue Aug 25, 2020
Merged
2 tasks
AICoE CI/CD Service automation moved this from New to Done Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goern goern

Labels
good first issue Good for newcomers hacktoberfest Issues targeting the hacktoberfest participants. human_intervention_required kind/feature Categorizes issue or PR as related to a new feature.
Projects
AICoE CI/CD Service
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tag created by pipeline has a pr- prefix goern/aicoe-ci
2 participants
@goern @vpavlin