JS module for uploading and fetching object URLs in Linode Object Storage #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abose
approved these changes
Jan 7, 2022
| "node-fetch": "^3.0.0", | ||
| "path": "^0.12.7", | ||
| "url-join": "^4.0.1", | ||
| "winston": "^3.3.3" |
There was a problem hiding this comment.
My bad removed unused lib Winston.
abose
reviewed
Jan 9, 2022
| }, | ||
| "author": "ushmajit", | ||
| "type": "module", | ||
| "license": "ISC" |
abose
reviewed
Jan 9, 2022
| * @param bucket uniquely identifies the bucket where the file should be uploaded | ||
| * @returns {Promise<void>} | ||
| */ | ||
| async function uploadFileToLinodeBucket (accessKeyId, secretAccessKey, region, file, bucket) { |
There was a problem hiding this comment.
Would be nice to have some predefined constants for regions
There was a problem hiding this comment.
Sure, makes sense, created an issue to track this #3
|
Unit test notes: |
|
|
Done. I have updated https://github.com/aicore/template-nodejs with best practices we follow for brackets and phoenix.
Just copy and merge the contents of the repo here to get all the functions. Follow readme. :) |
|
Thanks for the template files, copied all the relevant files from the template to the module. This is the new PR #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested the module by writing a sample node starter file and then resuing the module.
Expected behavior verified :