Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use G4OpticalParameters to set Cerenkov/Scintillation parameters #869

Merged
merged 7 commits into from
Sep 7, 2021
Merged

Use G4OpticalParameters to set Cerenkov/Scintillation parameters #869

merged 7 commits into from
Sep 7, 2021

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Sep 3, 2021

This introduces the use of G4OpticalParameters for setting of optical processes, cerenkov, and scintillation since the former approach ceased working as of geant4.10.7.

BEGINRELEASENOTES

  • Use G4OpticalParameters in geant4.10.7 and newer

ENDRELEASENOTES

@wdconinc
Copy link
Contributor Author

wdconinc commented Sep 3, 2021

Addresses #868

@wdconinc wdconinc changed the title Cerenkov scintillation optical parameters Use G4OpticalParameters to set Cerenkov/Scintillation parameters Sep 3, 2021
andresailer
andresailer reviewed Sep 6, 2021
View reviewed changes
Copy link
Member

@andresailer andresailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these fixes!

DDG4/plugins/Geant4OpticalPhotonPhysics.cpp Show resolved Hide resolved
DDG4/plugins/Geant4ScintillationPhysics.cpp Show resolved Hide resolved
andresailer
andresailer approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@andresailer andresailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing the additional options as well!

@andresailer andresailer merged commit b8d3148 into AIDASoft:master Sep 7, 2021
@andresailer andresailer linked an issue Sep 7, 2021 that may be closed by this pull request
Geant4CerenkovPhysics and geant4.10.7: changing Cerenkov settings not possible #868
Closed
@wdconinc wdconinc deleted the cerenkov-scintillation-optical-parameters branch September 23, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresailer andresailer andresailer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Geant4CerenkovPhysics and geant4.10.7: changing Cerenkov settings not possible
2 participants
@wdconinc @andresailer