refactor(block): do not convert unless uncached

aidenybai · Feb 15, 2022 · 7647b35 · 7647b35
1 parent 089dd1e
commit 7647b35
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 12 deletions.
diff --git a/package.json b/package.json
@@ -122,7 +122,7 @@
     "typescript": "^4.5.5",
     "unbuild": "^0.6.9",
     "virtual-dom": "^2.1.1",
-    "vite": "^2.8.2",
+    "vite": "^2.8.3",
     "vite-plugin-legacy": "^2.1.0",
     "vitest": "^0.2.8",
     "zx": "^4.3.0"

diff --git a/packages/block/block.ts b/packages/block/block.ts
@@ -5,12 +5,11 @@ import { fromDomNodeToVNode, fromStringToDomNode } from '../shared/convert';
 const cache = new Map<string, VEntity>();
 
 export const block = (html: string): VEntity => {
-  const el = fromStringToDomNode(html);
-  const vnode = fromDomNodeToVNode(el)!;
-
   if (cache.has(html)) {
     return cache.get(html)!;
   } else {
+    const el = fromStringToDomNode(html);
+    const vnode = fromDomNodeToVNode(el)!;
     const blockEntity = entity(
       {
         get el() {

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml