fix(createElement): ignore prop value with null and undefined

aidenybai · Jun 19, 2022 · c6ae6f7 · c6ae6f7
1 parent e0896e6
commit c6ae6f7
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 9 deletions.
diff --git a/src/million/createElement.ts b/src/million/createElement.ts
@@ -24,15 +24,17 @@ export const createElement = (vnode?: VNode | null, attachField = true): DOMNode
         } else if (propName.startsWith('xlink')) {
           el.setAttributeNS(XLINK_NS, 'href', String(propValue));
         }
-      } else if (
-        el[propName] !== undefined &&
-        el[propName] !== null &&
-        !(el instanceof SVGElement) &&
-        propName in el
-      ) {
-        el[propName] = propValue;
-      } else {
-        el.setAttribute(propName, String(propValue));
+      } else if (propValue !== undefined && propValue !== null) {
+        if (
+          el[propName] !== undefined &&
+          el[propName] !== null &&
+          !(el instanceof SVGElement) &&
+          propName in el
+        ) {
+          el[propName] = propValue;
+        } else {
+          el.setAttribute(propName, String(propValue));
+        }
       }
     }
   }

diff --git a/test/createElement.test.ts b/test/createElement.test.ts
@@ -58,4 +58,12 @@ describe.concurrent('createElement', () => {
     const el = document.createComment('');
     expectEqualNode(createElement(null), el);
   });
+
+  it('should not set prop value with null and undefined', () => {
+    const el = document.createElement('div');
+    el.id = '0';
+    el.setAttribute('bar', 'false');
+    el.appendChild(document.createTextNode('foo'));
+    expectEqualNode(createElement(m('div', { id: 0, children: undefined, foo: null, bar: false }, ['foo'])), el);
+  });
 });