Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: do not set readonly property. #192

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Conversation

cbbfcd
Copy link
Contributor

@cbbfcd cbbfcd commented Jun 16, 2022

fixed: [#191 ]

refer to: hyperapp

Please describe the changes this PR makes and why it should be merged:
bug fixed.
Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

src/million/createElement.ts Show resolved Hide resolved
@aidenybai
Copy link
Owner

LGTM, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants