fix(createElement): ignore prop value with null and undefined

[SukkaW]

Please describe the changes this PR makes and why it should be merged:

Status

• Code changes have been tested against prettier, or there are no code changes
• I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

• This PR changes the codebase
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
• This PR only includes non-code changes, like changes to documentation, README, etc.

I am using JSX with babel automatic runtime transformation and got Uncaught TypeError: setting getter-only property "children". It is caused by jsx function that set props.children to undefined:

million/src/jsx-runtime/jsx.ts

Line 12 in e0896e6

props.children = undefined;

However, createElement will always set prop (including children) even if the prop is read-only and the prop value is undefined. The PR adds an additional null and undefined check before applying props. The corresponding test case has also been added as well.

[aidenybai]

Looks good, could you also make this change in useProps.ts as well?

[SukkaW]

Looks good, could you also make this change in useProps.ts as well?

I have checked useProps, it has already included a prop value check:

million/src/million/drivers/useProps.ts

Lines 47 to 49 in e0896e6

	if (newPropValue) {
	queueEffect(EffectTypes.SET_PROP, () => (el[propName] = newPropValue));
	} else {

It should not be affected.

[aidenybai]

Cool, thanks for the help! Will be pushed out in the next patch

[aidenybai]

Hey! I seen you've made some PR's to the Million repo, If you'd be willing I'm extending an invitation for you to become a collaborator :)

Link: https://github.com/aidenybai/million/invitations