Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in tests and readability of createElement fn #35

Merged
merged 1 commit into from
Jun 19, 2021

Conversation

felippe-regazio
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

This PR makes some simple improvements for createElement function/tests by increasing readability and turning the function smaller. Also apply some DRY rules to test/createElement.

A small performance (time complexity) improvement can be considered since there is only a single call to create an element instead many attributions, also a forEach loop has downsized the needing of some allocations downing the space complexity, but I think these points are tiny and almost imperceptible.

Obs: i didnt created a new build since i dont know if i should do it (?).

Status

  • Code changes have been tested against prettier, or there are no code changes
  • [ x ] I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • [ x ] This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • [ x ] This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@netlify
Copy link

netlify bot commented Jun 19, 2021

✔️ Deploy Preview for million-benchmarks ready!

🔨 Explore the source changes: c9af890

🔍 Inspect the deploy log: https://app.netlify.com/sites/million-benchmarks/deploys/60cd7cb3fc69ce0007cd33c2

😎 Browse the preview: https://deploy-preview-35--million-benchmarks.netlify.app

@aidenybai
Copy link
Owner

LGTM!

@aidenybai aidenybai merged commit 092a151 into aidenybai:main Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants