Improvements in tests and readability of createElement fn #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR makes some simple improvements for createElement function/tests by increasing readability and turning the function smaller. Also apply some DRY rules to test/createElement.
A small performance (time complexity) improvement can be considered since there is only a single call to create an element instead many attributions, also a forEach loop has downsized the needing of some allocations downing the space complexity, but I think these points are tiny and almost imperceptible.
Obs: i didnt created a new build since i dont know if i should do it (?).
Status
Semantic versioning classification: