Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed your README links :) #527

Merged
merged 1 commit into from Aug 13, 2023
Merged

Conversation

Sidd-underscore
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

In the README, the links did not start with https://, so GitHub thought they were part of the repo 🤦🏽

Status

  • [ x ] Code changes have been tested against prettier, or there are no code changes
  • [ x ] I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • [ x ] This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Aug 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2023 10:31pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2023 10:31pm

@CLAassistant
Copy link

CLAassistant commented Aug 13, 2023

CLA assistant check
All committers have signed the CLA.

@aidenybai
Copy link
Owner

lgtm!!

@aidenybai aidenybai merged commit a602697 into aidenybai:main Aug 13, 2023
4 of 5 checks passed
@Sidd-underscore Sidd-underscore deleted the main-1 branch August 18, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants