Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather App #635

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Weather App #635

merged 5 commits into from
Oct 4, 2023

Conversation

cyberviking5
Copy link
Contributor

@cyberviking5 cyberviking5 commented Oct 2, 2023

Please describe the changes this PR makes and why it should be merged:
I have made a weather app which shows the temperature of the city entered along with the weather description . It is done in typescript and all the correct methods are followed .
Screenshot from 2023-10-02 19-17-30
Screenshot from 2023-10-02 21-34-30

If you want any changes please inform me :)

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 7:25am
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 7:25am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 7:25am

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2023

CLA assistant check
All committers have signed the CLA.

@aidenybai
Copy link
Owner

Please run pnpm run cleanup @cyberviking5

@cyberviking5
Copy link
Contributor Author

@aidenybai please check it and let me know if i have make any more changes :) . Thanks !

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove console logs @cyberviking5? Thanks. Also, did you try using block on the main Weather component being exported?

@cyberviking5
Copy link
Contributor Author

@tobySolutions i have removed the consoles and also i did try using block in the main weather components but it was showing some error . Please review the changes and let me know if you want any more changes :)

@cyberviking5
Copy link
Contributor Author

@tobySolutions please review the changes and please let me know if i have to make any changes :)

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@tobySolutions tobySolutions merged commit 9bd4642 into aidenybai:main Oct 4, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants