-
-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weather App #635
Weather App #635
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Please run |
@aidenybai please check it and let me know if i have make any more changes :) . Thanks ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please remove console logs @cyberviking5? Thanks. Also, did you try using block
on the main Weather component being exported?
b896989
to
22165c9
Compare
@tobySolutions i have removed the consoles and also i did try using block in the main weather components but it was showing some error . Please review the changes and let me know if you want any more changes :) |
@tobySolutions please review the changes and please let me know if i have to make any changes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Please describe the changes this PR makes and why it should be merged:
![Screenshot from 2023-10-02 19-17-30](https://private-user-images.githubusercontent.com/119874648/271987839-8ae69c37-c877-4a7a-82af-f15061cbcc3a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxMTgyMzIsIm5iZiI6MTcyMjExNzkzMiwicGF0aCI6Ii8xMTk4NzQ2NDgvMjcxOTg3ODM5LThhZTY5YzM3LWM4NzctNGE3YS04MmFmLWYxNTA2MWNiY2MzYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzI3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyN1QyMjA1MzJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03NzIyYmIwMWZkZjg5Njc4ZmUxOTg5ODk5ZGQ5YjQ2NTIzNmE2N2I4YTE1Y2Y0MmYzMjYwZjljMDNmNDZlNjBjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.w39wEu8rg3hXFwdf2PROf_MEIZTk9Uh46_w8ZvFo5Hg)
![Screenshot from 2023-10-02 21-34-30](https://private-user-images.githubusercontent.com/119874648/272023672-b145bbf1-af12-4cd7-ba26-7a1c240b919f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxMTgyMzIsIm5iZiI6MTcyMjExNzkzMiwicGF0aCI6Ii8xMTk4NzQ2NDgvMjcyMDIzNjcyLWIxNDViYmYxLWFmMTItNGNkNy1iYTI2LTdhMWMyNDBiOTE5Zi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzI3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyN1QyMjA1MzJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04OGJiMWQ5OGJiNjQ4ZjE0OWNkNWNmMmQxOGZiNzY1NWM2OWVhODM5YzlhMzA2NTljNDkyNmIzZTgzMDI1MWY1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.p83RnWejwd2hoyN64GOV7REQlUvLoUQi8YxHtZrNDmI)
I have made a weather app which shows the temperature of the city entered along with the weather description . It is done in typescript and all the correct methods are followed .
If you want any changes please inform me :)
Status
Semantic versioning classification: