Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added calendar app #642

Merged
merged 9 commits into from Oct 8, 2023
Merged

added calendar app #642

merged 9 commits into from Oct 8, 2023

Conversation

ATREAY
Copy link
Contributor

@ATREAY ATREAY commented Oct 3, 2023

Please describe the changes this PR makes and why it should be merged:

added calendar app to Kitchen sink and this PR pertains the issue #608(Kitchen Sink: Build A Calendar App)

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Signed-off-by: Atreay Kukanur <66585295+ATREAY@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million ❌ Failed (Inspect) Oct 7, 2023 2:50am
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2023 2:50am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2023 2:50am

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2023

CLA assistant check
All committers have signed the CLA.

@Timonwa
Copy link
Contributor

Timonwa commented Oct 3, 2023

@ATREAY, thank you for the PR. I don't think this is what @tobySolutions meant when he said you should build a calendar app. The app is supposed to allow one to create events and reminders, the way Google calender does, am I right Tobi?

@ATREAY
Copy link
Contributor Author

ATREAY commented Oct 3, 2023

Hey @Timonwa, my bad for not getting the task, but let's wait and see what @tobySolutions suggests, and I'll make the changes based on that.

@Timonwa
Copy link
Contributor

Timonwa commented Oct 3, 2023

Sure, no problem.

@tobySolutions
Copy link
Contributor

Um, yes @ATREAY. Timonwa is right. You can make your changes based on her feedback 😁

@ATREAY
Copy link
Contributor Author

ATREAY commented Oct 3, 2023

Ok @tobySolutions, I will make the changes accordingly.

@ATREAY
Copy link
Contributor Author

ATREAY commented Oct 4, 2023

Hey @tobySolutions, I'm having trouble with Vercel deployment. I'm not sure why, as I've run pnpm i correctly, but when I try pnpm build I'm hitting this error.
image

@tobySolutions
Copy link
Contributor

Hey there @ATREAY! Sorry, what errors are you hitting? Also, can you check out your push? It looks like you have merge conflicts.

@ATREAY
Copy link
Contributor Author

ATREAY commented Oct 5, 2023

Hey @tobySolutions, I've sorted out the conflict. Can you please check it out?

@Timonwa
Copy link
Contributor

Timonwa commented Oct 5, 2023

This is a lot better. If you could stack the docs on each other on mobile screen, it would be perfect. And also the text doesn't show well in light mode.

25CB9A8E-706F-4575-8074-E1C0C52D0AF4

@ATREAY
Copy link
Contributor Author

ATREAY commented Oct 5, 2023

Sure thing, @Timonwa! I'll get to work on it and redo the changes.

@ATREAY
Copy link
Contributor Author

ATREAY commented Oct 6, 2023

Hi @Timonwa and @tobySolutions, I've made the necessary updates. Could you please take a look when you have a moment?

@tobySolutions
Copy link
Contributor

Hey there @ATREAY! Good work. Could you maybe try resolving the merge conflict you have? Thanks!

@ATREAY
Copy link
Contributor Author

ATREAY commented Oct 7, 2023

Hey @tobySolutions, could you check it out? I've fixed the merge conflict.

@tobySolutions
Copy link
Contributor

Hey @tobySolutions, could you check it out? I've fixed the merge conflict.

Awesome! Thanks. I'm reviewing it now.

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work!

@tobySolutions tobySolutions merged commit 17939d0 into aidenybai:main Oct 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants