Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kitchen Sink: Build A Location-Based App #647

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

arunavabasucom
Copy link
Contributor

@arunavabasucom arunavabasucom commented Oct 3, 2023

Please describe the changes this PR makes and why it should be merged:
This PR aims to demonstrate a location app example using million .

Status
Closes : #610

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 4:06pm
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 4:06pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 4:06pm

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job

@tobySolutions
Copy link
Contributor

Fixes #610

@tobySolutions tobySolutions merged commit 87654d1 into aidenybai:main Oct 4, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kitchen Sink: Build A Location-Based App
3 participants