Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/url shortner #664

Merged
merged 4 commits into from Oct 6, 2023
Merged

Feat/url shortner #664

merged 4 commits into from Oct 6, 2023

Conversation

Abhishek-Mallick
Copy link
Contributor

@Abhishek-Mallick Abhishek-Mallick commented Oct 5, 2023 •
edited

Please describe the changes this PR makes and why it should be merged:
This PR aims to demonstrate a url-shortner example using million incorporated with a shrcto API.

Status
Closes : #625

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
2023-10-05.11-45-03.mp4

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Oct 5, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 9:06pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 9:06pm

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@Abhishek-Mallick Abhishek-Mallick mentioned this pull request Oct 5, 2023
Closed
@deeola
Copy link
Contributor

deeola commented Oct 5, 2023

LGTM

@Timonwa
Copy link
Contributor

Timonwa commented Oct 5, 2023

Hi @Abhishek-Mallick, the purpose of this exercise is to show how to use Million.js in different instance. Please incorporate Million.js into your project.

@Abhishek-Mallick
Copy link
Contributor Author

Hey @Timonwa, I have made the necessary changes #664

  • Incorporated million
  • Component functions as before

tobySolutions
tobySolutions approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@tobySolutions tobySolutions merged commit fa0e188 into aidenybai:main Oct 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deeola deeola deeola approved these changes

@tobySolutions tobySolutions tobySolutions approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kitchen Sink: Build A URL Shortener
5 participants
@Abhishek-Mallick @CLAassistant @deeola @Timonwa @tobySolutions