Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dice roller feature #684

Merged
merged 4 commits into from Oct 8, 2023
Merged

Conversation

UzairNoman
Copy link
Contributor

@UzairNoman UzairNoman commented Oct 5, 2023

Please describe the changes this PR makes and why it should be merged:
Added dice roller app feature with nice CSS effect.
Closes #672

Status

  • [x ] Code changes have been tested against prettier, or there are no code changes
  • [x ] I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 10:34pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 10:34pm

@tobySolutions
Copy link
Contributor

Hey there @UzairNoman, can you fix your merge conflicts please? Thanks!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6437087539

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.706%

Totals Coverage Status
Change from base Build 6437024710: 0.0%
Covered Lines: 1257
Relevant Lines: 5082

💛 - Coveralls

@tobySolutions
Copy link
Contributor

Hmm, awesome! Checking it out now.

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@tobySolutions
Copy link
Contributor

Good job @UzairNoman.

@tobySolutions tobySolutions merged commit 5030496 into aidenybai:main Oct 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kitchen Sink : Virtual Dice Roller
3 participants