Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kitchen Sink: Build A Flashcard Vocabulary Game #618 #709

Merged

Conversation

grbknr1996
Copy link
Contributor

@grbknr1996 grbknr1996 commented Oct 8, 2023

Please describe the changes this PR makes and why it should be merged:

Created a vocabulary quiz game with flash card and million.js. This issue is for hacktober fest

scrnli_10_8_2023_11-52-39.PM.webm

Status
Solves Issue #618

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • [] This PR changes the codebase
    • [] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • [] This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • [] This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Oct 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 6:37pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 6:37pm

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@Timonwa Timonwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @grbknr1996, is it supposed to show the answer to the quiz when you click on the card? I think it would be best to show the answer when you click on check, and the answer is correct, or/and have a show answer button.

overall, this looks good to me. Nice work!

@grbknr1996
Copy link
Contributor Author

Hi @grbknr1996, is it supposed to show the answer to the quiz when you click on the card? I think it would be best to show the answer when you click on check, and the answer is correct, or/and have a show answer button.

overall, this looks good to me. Nice work!

Hi @Timonwa ,

Sure will be Incorporating the same

@grbknr1996
Copy link
Contributor Author

grbknr1996 commented Oct 10, 2023

Hi @grbknr1996, is it supposed to show the answer to the quiz when you click on the card? I think it would be best to show the answer when you click on check, and the answer is correct, or/and have a show answer button.
overall, this looks good to me. Nice work!

Hi @Timonwa ,

Sure will be Incorporating the same

Added the functionalities to flip card on incorrect.
Please let me know if anything needed to be added
PFA : Working video
scrnli_10_11_2023_12-02-14 AM.webm

Also if everything is fine, if you can add the hacktoberfest accepted label. Thanks in advance

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! LGTM!

@tobySolutions tobySolutions merged commit 728e2e9 into aidenybai:main Oct 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants