Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/kitchen sink example of task tracker with drag and drop #710

Conversation

devhd9
Copy link
Contributor

@devhd9 devhd9 commented Oct 8, 2023

Please describe the changes this PR makes and why it should be merged:
Task-Tracker with drag and drop example added for kitchen sink. Which refers to issue #602.

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Sample video of example

Screen.Recording.2023-10-08.at.11.47.26.PM.mov

@vercel
Copy link

vercel bot commented Oct 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 10:24am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 10:24am

Copy link
Contributor

@Timonwa Timonwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. I have only one suggestion. Can the To Do text be red, In Progress be yellow, and Completed be green?

@devhd9
Copy link
Contributor Author

devhd9 commented Oct 9, 2023

Hey @Timonwa, thanks for the suggestion. I have applied changes, kindly check it.

@Timonwa
Copy link
Contributor

Timonwa commented Oct 10, 2023

@devhd9 , awesome. 👍🏽
@tobySolutions is ready to be merged.

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job @devhd9. Could you maybe fix the mobile view?

Screenshot 2023-10-10 at 08 26 27

@tobySolutions
Copy link
Contributor

Any updates on this @devhd9?

@devhd9
Copy link
Contributor Author

devhd9 commented Oct 12, 2023

Hi @tobySolutions, apologies for the delay, I was occupied earlier. I have made changes. Kindly review it.

@tobySolutions
Copy link
Contributor

Hi @tobySolutions, apologies for the delay, I was occupied earlier. I have made changes. Kindly review it.

Awesome! Taking a look now.

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM!

@tobySolutions tobySolutions merged commit ab34113 into aidenybai:main Oct 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants