Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve kitchen sink #829

Merged
merged 17 commits into from Nov 13, 2023
Merged

Conversation

Timonwa
Copy link
Contributor

@Timonwa Timonwa commented Nov 13, 2023

Please describe the changes this PR makes and why it should be merged:
Most of the projects are not mobile-responsive. Some texts are only visible in dark mode. Some needed UI enhancement. I have updated/cross-checked around 15 to 20 of them. I will continue the rest in a new PR.

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 7:56am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 7:56am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! A maintainer will review it soon.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6847114463

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.706%

Totals Coverage Status
Change from base Build 6834095086: 0.0%
Covered Lines: 1257
Relevant Lines: 5082

💛 - Coveralls

@Timonwa
Copy link
Contributor Author

Timonwa commented Nov 13, 2023

@tobySolutions check it out.

@tobySolutions
Copy link
Contributor

Awesome! Thanks it's under review.

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job @Timonwa!

@tobySolutions tobySolutions merged commit afc6dfc into aidenybai:main Nov 13, 2023
8 of 9 checks passed
Aslemammad pushed a commit that referenced this pull request Jan 2, 2024
* age calculator done

* bmi calculator done

* book recommendation done

* calculator is done

* countdown timer done

* context done

* currency converter done

* data converter done

* dice roller done

* digital journal done

* carousel done

* discount calculator done

* currency converter done

* create event calender done

* fix: fixed a merge issue

* ran cleanup scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants