Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed the million package installation by adding choice to use legacy-peer-deps flag. #857

Merged
merged 6 commits into from Dec 29, 2023

Conversation

Drex72
Copy link
Contributor

@Drex72 Drex72 commented Dec 29, 2023

Please describe the changes this PR makes and why it should be merged:

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Copy link

vercel bot commented Dec 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 29, 2023 11:32am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 29, 2023 11:32am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! A maintainer will review it soon.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7356253240

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.706%

Totals Coverage Status
Change from base Build 7356113341: 0.0%
Covered Lines: 1257
Relevant Lines: 5082

💛 - Coveralls

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @Drex72 LGTM!

@tobySolutions tobySolutions merged commit 8b75c1b into aidenybai:main Dec 29, 2023
7 checks passed
Aslemammad pushed a commit that referenced this pull request Jan 2, 2024
…egacy-peer-deps flag. (#857)

* fixed the package installation issue

* added the legacy-peer-deps flag

* removed dependencies

* fixed linting issues

* made changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants