Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation(i18n): Translate the docs to Spanish #923

Merged
merged 13 commits into from
Jan 31, 2024
Merged

Documentation(i18n): Translate the docs to Spanish #923

merged 13 commits into from
Jan 31, 2024

Conversation

glitch-txs
Copy link
Contributor

@glitch-txs glitch-txs commented Jan 26, 2024

Please describe the changes this PR makes and why it should be merged:

  • Automatic Mode
  • Install
  • Introduction

Manual Mode

  • Block
  • For
  • Manual Mode
  • Virtualization

Internals

  • Block
  • Map Array
  • Mount
  • Patch
  • Render to Template
  • String to DOM

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

closes #907

Copy link

vercel bot commented Jan 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 9:47pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 9:47pm

@CLAassistant
Copy link

CLAassistant commented Jan 26, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! A maintainer will review it soon.

@tobySolutions
Copy link
Contributor

Awesome work @glitch-txs!! Thanks.

@glitch-txs
Copy link
Contributor Author

thanks! @tobySolutions!
I think it's done, could you review?

For some reason /es-ES/docs/manual-mode/for gives me 404 as well on local

@glitch-txs glitch-txs marked this pull request as ready for review January 28, 2024 14:47
@tobySolutions
Copy link
Contributor

Awesome!!! Thanks @glitch-txs 🙌🙌🙌. I'll review it in a bit.

@tobySolutions
Copy link
Contributor

thanks! @tobySolutions!
I think it's done, could you review?

For some reason /es-ES/docs/manual-mode/for gives me 404 as well on local

It does not work in prod as well? I'll check it out and let you know.

That's certainly weird.

@glitch-txs
Copy link
Contributor Author

haven't tried on prod, will give it one last read to the whole thing just in case

@glitch-txs
Copy link
Contributor Author

there are some warning that are written in English because they are components, may we could make this components to receive a prop with the text so it can be trasnlated on the dif pages
image

@glitch-txs
Copy link
Contributor Author

also this part seems off from main docs, it's talking about the For component but the example shows a block?
image

@coveralls
Copy link

coveralls commented Jan 28, 2024

Pull Request Test Coverage Report for Build 7702882312

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.706%

Totals Coverage Status
Change from base Build 7699303649: 0.0%
Covered Lines: 1257
Relevant Lines: 5082

💛 - Coveralls

@tobySolutions
Copy link
Contributor

there are some warning that are written in English because they are components, may we could make this components to receive a prop with the text so it can be trasnlated on the dif pages image

Hmm, do you want to work on that?

@tobySolutions
Copy link
Contributor

also this part seems off from main docs, it's talking about the For component but the example shows a block? image

Oh, the as is right there; it's the thing with the as: div

@glitch-txs
Copy link
Contributor Author

Hmm, do you want to work on that?

sure, since it might be breaking change for other languages we can do it in another PR if that's ok

@tobySolutions
Copy link
Contributor

tobySolutions commented Jan 28, 2024

Hmm, do you want to work on that?

sure, since it might be breaking change for other languages we can do it in another PR if that's ok

Yeah, much later on. Can you pull latest changes? I just committed something directly to main.

@tobySolutions
Copy link
Contributor

Reviewing it now @glitch-txs

@glitch-txs
Copy link
Contributor Author

Thanks! Let me know if there any changes left 🫡

@tobySolutions
Copy link
Contributor

Thanks! Let me know if there any changes left 🫡

Ok, so I fixed the For page issue. I'm making a push now

@tobySolutions
Copy link
Contributor

Great work @glitch-txs!! Thanks 🙌

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks!

@tobySolutions tobySolutions merged commit 3425d79 into aidenybai:main Jan 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📝 Documentation(i18n): Translate the docs to Spanish
4 participants