Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Translate blogs to spanish (WIP) #924

Merged
merged 17 commits into from Jan 31, 2024
Merged

docs: Translate blogs to spanish (WIP) #924

merged 17 commits into from Jan 31, 2024

Conversation

oliverloops
Copy link
Contributor

@oliverloops oliverloops commented Jan 26, 2024 •
edited

Please describe the changes this PR makes and why it should be merged:

Blogs already translated

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel Vercel
Copy link

vercel bot commented Jan 26, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 7:46am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 7:46am

github-actions[bot]
github-actions bot reviewed Jan 26, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! A maintainer will review it soon.

@coveralls
Copy link

coveralls commented Jan 26, 2024 •
edited

Pull Request Test Coverage Report for Build 7707856717

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.706%
Totals Coverage Status
Change from base Build 7699303649: 0.0%
Covered Lines: 1257
Relevant Lines: 5082
💛 - Coveralls

@tobySolutions
Copy link
Contributor

Hello there @oliverloops; did you mean to make this a draft pull request? Cos there is no commit here and it says 0 files changed:

Screenshot 2024-01-26 at 20 33 33

@oliverloops
Copy link
Contributor Author

oliverloops commented Jan 26, 2024 •
edited

Yes, this is a draft PR, I saw the first three blog translations were merged into the first PR on (Foundation translation). I'll be adding the remaining commit blog translations on this same PR. sorry for this confusion. So please don't merge until this task is complete.

@tobySolutions
Copy link
Contributor

Ok, awesome @oliverloops, thanks!!

@oliverloops oliverloops changed the title docs: Translate blogs to spanish docs: Translate blogs to spanish (WIP) Jan 27, 2024
tobySolutions
tobySolutions approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@tobySolutions tobySolutions merged commit a25f703 into aidenybai:main Jan 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@tobySolutions tobySolutions tobySolutions approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oliverloops @coveralls @tobySolutions