New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(experimental): remove slots for blocks #948
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! A maintainer will review it soon.
Hmm, I like this idea 🤔🤔. I think it's a good start. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Aslemammad
force-pushed
the
experimental/remove-slot
branch
from
February 10, 2024 05:36
39e1121
to
8b8abeb
Compare
Aslemammad
force-pushed
the
experimental/remove-slot
branch
from
February 18, 2024 08:11
39f8b20
to
defb574
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only way to resolve this is to divide and conquer it! After 3 implementations, all of them failed and I don't think we can deal with this easily.
I decided to divide this feature/breaking-change into multiple parts and add them with the
experimental_options.noSlot
flag or theexperimental_noSlot
prop.In this PR, I remove slots from blocks only and it does not even support siblings yet (or maybe never) but that's a good start I think.
We ship this to the users with those flags and see their reactions and responses!
The way to try this is to do this:
Now I kinda understand why React is doing what it's doing with the experimental releases.