Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): remove slots for blocks #948

Merged
merged 19 commits into from Feb 24, 2024
Merged

Conversation

Aslemammad
Copy link
Collaborator

The only way to resolve this is to divide and conquer it! After 3 implementations, all of them failed and I don't think we can deal with this easily.

I decided to divide this feature/breaking-change into multiple parts and add them with the experimental_options.noSlot flag or the experimental_noSlot prop.

In this PR, I remove slots from blocks only and it does not even support siblings yet (or maybe never) but that's a good start I think.

We ship this to the users with those flags and see their reactions and responses!

The way to try this is to do this:

import { experimental_options }} from 'million/experimental'

experimental_options.noSlot = true;

// or 

block(() => ..., { experimental_noSlot: true })

Now I kinda understand why React is doing what it's doing with the experimental releases.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! A maintainer will review it soon.

@tobySolutions
Copy link
Contributor

Hmm, I like this idea 🤔🤔. I think it's a good start.

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 6:26am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 6:26am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants