New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue67 #91
base: master
Are you sure you want to change the base?
Issue67 #91
Conversation
Sorry I found a bug on this branch. don't merge it until the next commit. |
done :) |
Wow! Thanks for all the work! |
The overal of you design is excellent. It was a good idea to have a There's some little problems with the implementation.
In other words: Encapsulation ;-) If I couldn't explain it clearly, I can send you a UML and pseudo code. |
Also, please consider formatting. Things like space after |
Thanks my friend for the remarks :). you are right. |
:D |
What's up, Yassine? (: |
hello Aidin, hope you're fine. |
Thanks Yassine (: I'm waiting for that. |
I'm thinking of adding others wild cards ( '?', '{ }', ...) in the future, I think I'd use the "Trie" algorithm, not sure though. Anyway, now it's only the asterisk wild card that is implemented in this commit.
I've used Singleton design pattern in the submited code, so if you don't like it I'll find another way.