Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mpi example #121

Merged
merged 13 commits into from
Feb 13, 2023
Merged

Mpi example #121

merged 13 commits into from
Feb 13, 2023

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Feb 1, 2023

Description

Summary of changes

  • Added an example how to use MPI
  • Small fixes in constellation notebook
  • Added check of constraint function
  • Added list of example to README

Resolved Issues

How Has This Been Tested?

Running the script

Related Pull Requests

N/A

@gomezzz gomezzz added documentation Improvements or additions to documentation example An example to showcase something user-facing Anything that users can interact with labels Feb 1, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@GabrieleMeoni GabrieleMeoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me. Notice that I first tried to install mpi4py by using pip on Windows. It led to DLL errors, so I had to reinstall it by using conda. Now it works.

README.md Outdated Show resolved Hide resolved
examples/MPI_example/mpi_example.py Outdated Show resolved Hide resolved
line of sight of each other. For simplicity, the modelled task here will be to count the number of
window encounters for each satellite.

N.B. There are some simplifications in this example. Running this on a larger scale
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not really clear what you mean here. I would rephrase it.

examples/MPI_example/mpi_example.py Outdated Show resolved Hide resolved
# Synchronize between and print some stats.
comm.Barrier()
end = time.time()
sys.stdout.flush()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you comment what is used for?

examples/MPI_example/mpi_utility_func.py Outdated Show resolved Hide resolved
gomezzz and others added 3 commits February 6, 2023 11:17
Co-authored-by: Gabriele Meoni <70584239+GabrieleMeoni@users.noreply.github.com>
@gomezzz gomezzz merged commit 4372346 into main Feb 13, 2023
@gomezzz gomezzz deleted the MPI-Example branch February 13, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation example An example to showcase something user-facing Anything that users can interact with
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MPI Example
2 participants