Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve los customizability #152

Merged
merged 8 commits into from
Feb 28, 2023
Merged

Improve los customizability #152

merged 8 commits into from
Feb 28, 2023

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Feb 27, 2023

Description

Summary of changes

  • Added cfg parameter to allow setting radius of the sphere blocking line of sight
  • Changed default radius to 6451km
  • Some minor refactoring to account for the change
  • Minor string changes

Resolved Issues

How Has This Been Tested?

CI/CD

Related Pull Requests

N/A

paseos/resources/default_cfg.toml Outdated Show resolved Hide resolved
paseos/tests/line_of_sight_test.py Outdated Show resolved Hide resolved
@@ -143,6 +147,9 @@ def test_communication_link_sat_to_sat():
central_body=earth,
)

sat1.set_central_body_shape(Sphere([0, 0, 0], 6371000))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

earth_radius = 6371000

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made it a constant in test_utils instead ✌️

@johanos1 johanos1 self-requested a review February 27, 2023 16:00
@gomezzz gomezzz requested review from johanos1 and removed request for johanos1 February 27, 2023 16:21
@gomezzz gomezzz merged commit dd62a90 into main Feb 28, 2023
@gomezzz gomezzz deleted the improve-LOS-customizability branch February 28, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inter-satellite link model
2 participants