-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom meshes & rotations #182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I like that some of the previous free functions moved inside the actor class - which facilities the usage for the user. The CentralBody
class and associated functions look fine as well.
Otherwise some minor comments for the wine 🍷algorithm. (and to the already pointed out magic number, but now in the test cases)
paseos/tests/mesh_test.py
Outdated
# Load the 67P mesh with pickle | ||
with open(mesh_path, "rb") as f: | ||
mesh_points, mesh_triangles = pickle.load(f) | ||
mesh_points = np.array(mesh_points) * 3126.6064453124995 # Scale to m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Magic Scaling number as a constant to the top of the file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a comment ✌️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, well done!✌️
Description
Summary of changes
get_communication_window.py
for readabilityResolved Issues
How Has This Been Tested?
Related Pull Requests
N/A
Visualization with mesh looks like this
![mesh_test](https://private-user-images.githubusercontent.com/2656685/254280148-7fbe4d72-3a0f-413a-9177-f13dccf8f8eb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQxMjAwMTQsIm5iZiI6MTcyNDExOTcxNCwicGF0aCI6Ii8yNjU2Njg1LzI1NDI4MDE0OC03ZmJlNGQ3Mi0zYTBmLTQxM2EtOTE3Ny1mMTNkY2NmOGY4ZWIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjBUMDIwODM0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZjlkMmIxMGVkYzIzYWZjYTBkZTgyZWQwZjIyMTYzNDk3Y2Q2M2VkMzljYzA3ZWU2YWVhMjg0N2FlYTI5M2ZiMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.zqwYpm30oNffunWOi2haeCxTpbBYSYfdFnHuc2Cszfg)
@schuhmaj @rasmusmarak Your comments would also be appreciated 🙏
ToDos