OS X crash on import paseos when pip installed #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomezzz
requested changes
Nov 28, 2022
README.md
Outdated
| @@ -7,7 +7,7 @@ This project is currently under development. Use at your own risk. :) | |||
|
|
|||
| <p align="center"> | |||
| <a href="https://github.com/aidotse/PASEOS/"> | |||
| <img src="resources/images/datastructure.svg" alt="Scheme" width="910" height="459"> | |||
| <img src="paseos/resources/images/datastructure.svg" alt="Scheme" width="910" height="459"> | |||
There was a problem hiding this comment.
Let's keep the readme images (this and below 2) in the top-level folder resources, there is no need to ship them with the module and otherwise they have no reason to be in the module folder
| @@ -140,6 +140,6 @@ async def job(): | |||
| return job() | |||
| else: | |||
| # Run activity and processor | |||
| asyncio.run(job()) | |||
| asyncio.gather(job()) | |||
|
|
|||
| logger.info(f"Activity {activity} completed.") | |||
There was a problem hiding this comment.
pls remove the file paseos/resources/.DS_Store
|
|
||
|
|
||
| def test_activity(): | ||
| @pytest.mark.asyncio |
There was a problem hiding this comment.
Can you add a comment somewhere what this actually does, so we remember? :)
paseos/utils/load_default_cfg.py
Outdated
| ) | ||
| logger.debug(f"loading path: {path}") |
There was a problem hiding this comment.
Suggested change
| logger.debug(f"loading path: {path}") | |
| logger.debug(f"Loading default cfg from {path}") |
(can then remove above debugger output in Line9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
Resolved Issues
How Has This Been Tested?
Related Pull Requests