Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event based time advancement #90

Merged
merged 12 commits into from
Jan 3, 2023
Merged

Event based time advancement #90

merged 12 commits into from
Jan 3, 2023

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Dec 23, 2022

Description

Summary of changes

  • Added option for the user to use advance_time for physical models
  • Added test for event-based mode
  • Added more logging
  • Added README entry on this mode

Resolved Issues

How Has This Been Tested?

New test, CI

Related Pull Requests

Builds on #81 #89

@gomezzz gomezzz added enhancement New feature or request tests Anything related to the tests example An example to showcase something feature implementing a new feature user-facing Anything that users can interact with physical-model All things involving some physical models labels Dec 23, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@gomezzz gomezzz mentioned this pull request Dec 26, 2022
Merged
2 tasks
johanos1
johanos1 requested changes Jan 2, 2023
View reviewed changes
paseos/paseos.py Outdated Show resolved Hide resolved
paseos/paseos.py Show resolved Hide resolved
paseos/tests/event_based_test.py Outdated Show resolved Hide resolved
paseos/paseos.py Show resolved Hide resolved
paseos/tests/event_based_test.py Show resolved Hide resolved
@gomezzz gomezzz requested a review from johanos1 January 3, 2023 11:07
@gomezzz gomezzz merged commit dcb35e5 into main Jan 3, 2023
@gomezzz gomezzz deleted the Event-based-time-advancement branch January 3, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanos1 johanos1 johanos1 approved these changes

@GabrieleMeoni GabrieleMeoni Awaiting requested review from GabrieleMeoni

Assignees
No one assigned
Labels
enhancement New feature or request example An example to showcase something feature implementing a new feature physical-model All things involving some physical models tests Anything related to the tests user-facing Anything that users can interact with
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event-based time advancement
2 participants
@gomezzz @johanos1