Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor convenience functions #95

Merged
merged 5 commits into from
Jan 9, 2023
Merged

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Dec 26, 2022

Description

Summary of changes

  • Added option to plot monitored quantity
  • Added direct access to monitor for users
  • Expanded test

Resolved Issues

How Has This Been Tested?

New test, CI, will test more in #92

Related Pull Requests

Merge after #81 #89

@gomezzz gomezzz added enhancement New feature or request tests Anything related to the tests feature implementing a new feature user-facing Anything that users can interact with labels Dec 26, 2022
@gomezzz gomezzz mentioned this pull request Dec 26, 2022
2 tasks
@gomezzz gomezzz requested a review from johanos1 January 2, 2023 16:36
@gomezzz gomezzz changed the base branch from main to Constellation-example January 9, 2023 09:27
@gomezzz gomezzz changed the base branch from Constellation-example to main January 9, 2023 09:27
Copy link
Collaborator

@GabrieleMeoni GabrieleMeoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
It does not print anything to me (see screenshot. I copied your test in the main branch and I ran it). I also tried the simple activity in the read me and added two lines to plot but I am not getting any plot).

Can you also add an example to the README on how to use it?

@GabrieleMeoni
Copy link
Collaborator

It was an editor problem, which prevented me to edit the code for testing. Everything works fine.

@gomezzz gomezzz merged commit d0cf8ba into main Jan 9, 2023
@gomezzz gomezzz deleted the monitor-convenience-functions branch January 9, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature implementing a new feature tests Anything related to the tests user-facing Anything that users can interact with
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow plotting of actor's monitored attributes
2 participants