Skip to content
This repository has been archived by the owner on Mar 16, 2019. It is now read-only.

CA certs should be created when creating Admin MSP #25

Merged
merged 9 commits into from
Jan 17, 2019
Merged

CA certs should be created when creating Admin MSP #25

merged 9 commits into from
Jan 17, 2019

Conversation

alexvicegrab
Copy link
Contributor

This reduces the number of secrets we need to handle, by reducing duplication.

@alexvicegrab
[Example_dev] Add Development example [that uses CA]
5fd924f 
Signed-off-by: Alejandro Vicente Grabovetsky <sasha@aid.technology>
@alexvicegrab
[Example_prod] Add Production example
b9dad0b 
Signed-off-by: Alejandro Vicente Grabovetsky <sasha@aid.technology>
@alexvicegrab
[Helm_refactor] Rename 'name' parameter to 'release'
d5a0c64 
Signed-off-by: Alejandro Vicente Grabovetsky <sasha@aid.technology>
@alexvicegrab
[Helm_refactor] Add tests for 'helm_env_vars'
6e8a77e 
Signed-off-by: Alejandro Vicente Grabovetsky <sasha@aid.technology>
@alexvicegrab
[CA_certs] Add tests for 'item_to_secret'
da4b578 
Signed-off-by: Alejandro Vicente Grabovetsky <sasha@aid.technology>
@alexvicegrab
[CA_certs] Small fixes to domains
1cc302d 
Signed-off-by: Alejandro Vicente Grabovetsky <sasha@aid.technology>
@alexvicegrab
[Helm_refactor] Fix admin credential secret
5b99473 
Signed-off-by: Alejandro Vicente Grabovetsky <sasha@aid.technology>
@alexvicegrab
[CA_certs] fix issue in check_ord_tls
ff3ca3a 
Signed-off-by: Alejandro Vicente Grabovetsky <sasha@aid.technology>
@alexvicegrab
0.1.5
b572d6a 
Signed-off-by: Alejandro Vicente Grabovetsky <sasha@aid.technology>
@alexvicegrab alexvicegrab added enhancement New feature or request fabric labels Jan 16, 2019
@nicolapaoli nicolapaoli self-requested a review January 17, 2019 15:38
nicolapaoli
nicolapaoli approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@nicolapaoli nicolapaoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolapaoli nicolapaoli merged commit f4b43d5 into master Jan 17, 2019
@nicolapaoli nicolapaoli deleted the ca_certs branch January 17, 2019 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolapaoli nicolapaoli nicolapaoli approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request fabric
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexvicegrab @nicolapaoli