Skip to content
This repository has been archived by the owner on Mar 16, 2019. It is now read-only.

Logs Since #46

Merged
merged 2 commits into from
Feb 19, 2019
Merged

Logs Since #46

merged 2 commits into from
Feb 19, 2019

Conversation

alexvicegrab
Copy link
Contributor

Enable obtaining logs since a specific time.

Refactor rand_string to helpers/misc.py

Signed-off-by: Alejandro Vicente Grabovetsky <sasha@aid.technology>
… time

Signed-off-by: Alejandro Vicente Grabovetsky <sasha@aid.technology>
@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #46   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          19     19           
  Lines         888    891    +3     
=====================================
+ Hits          888    891    +3
Impacted Files Coverage Δ
nephos/fabric/utils.py 100% <100%> (ø) ⬆️
nephos/helpers/misc.py 100% <100%> (ø) ⬆️
nephos/helpers/k8s.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ba79b1...5ebfd14. Read the comment docs.

@alexvicegrab alexvicegrab self-assigned this Feb 18, 2019
@alexvicegrab alexvicegrab added the enhancement New feature or request label Feb 18, 2019
@alexvicegrab alexvicegrab added this to In progress in Planned improvements via automation Feb 18, 2019
Planned improvements automation moved this from In progress to Reviewer approved Feb 19, 2019
Copy link
Contributor

@nicolapaoli nicolapaoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will help to get specific sets of logs, thanks @alexvicegrab

@alexvicegrab alexvicegrab merged commit d386ec1 into master Feb 19, 2019
Planned improvements automation moved this from Reviewer approved to Done Feb 19, 2019
@alexvicegrab alexvicegrab deleted the logs_since branch February 19, 2019 12:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants