This repository has been archived by the owner on Jul 10, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 221
Support for cross-platform serialization of MLP. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Things to do: determinism test for all activation types comparing pre- and post-serialization — Maxout in particular. |
1 similar comment
1 similar comment
Ready for review @ssamot when you have time :-) |
Closes #7. |
…eturned by the serialisation. If it's numpy arrays' then it's guaranteed cross platform.
Addressed @ssamot's comments by adding a test to ensure that numpy.ndarrays are serialized to disk and not theano data-structures, ensuring platform compatibility. |
alexjc
added a commit
that referenced
this pull request
Apr 26, 2015
Support for cross-platform serialization of MLP.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The weights are now pickled instead of the MLP entirely. Additional objects such as
input_space
are required to_create_mlp()
once the de-pickling happens. Some tests in place, should be added to Classifier and Regressor tests too.Updates #7.