Skip to content
This repository has been archived by the owner on Jul 10, 2021. It is now read-only.

Support for cross-platform serialization of MLP. #16

Merged
merged 5 commits into from
Apr 26, 2015
Merged

Conversation

alexjc
Copy link
Member

@alexjc alexjc commented Apr 23, 2015

The weights are now pickled instead of the MLP entirely. Additional objects such as input_space are required to _create_mlp() once the de-pickling happens. Some tests in place, should be added to Classifier and Regressor tests too.

Updates #7.

@alexjc
Copy link
Member Author

alexjc commented Apr 23, 2015

Things to do: determinism test for all activation types comparing pre- and post-serialization — Maxout in particular.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.44%) to 98.56% when pulling 4343da5 on serialization into a57ac0c on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.44%) to 98.56% when pulling 4343da5 on serialization into a57ac0c on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d0c09f0 on serialization into a57ac0c on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d0c09f0 on serialization into a57ac0c on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9c33047 on serialization into a57ac0c on master.

@alexjc
Copy link
Member Author

alexjc commented Apr 25, 2015

Ready for review @ssamot when you have time :-)

@alexjc
Copy link
Member Author

alexjc commented Apr 25, 2015

Closes #7.

…eturned by the serialisation. If it's numpy arrays' then it's guaranteed cross platform.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8c32d48 on serialization into a57ac0c on master.

@alexjc
Copy link
Member Author

alexjc commented Apr 26, 2015

Addressed @ssamot's comments by adding a test to ensure that numpy.ndarrays are serialized to disk and not theano data-structures, ensuring platform compatibility.

alexjc added a commit that referenced this pull request Apr 26, 2015
Support for cross-platform serialization of MLP.
@alexjc alexjc merged commit c638eef into master Apr 26, 2015
@alexjc alexjc deleted the serialization branch April 26, 2015 09:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants